Skip to content
Success

Changes

Summary

  1. docker-py: skip PullImageTest::test_pull_invalid_platform (details)
  2. Dockerfile: use DEBIAN_FRONTEND=noninteractive (details)
  3. Jenkinsfile: move static and cross compilation to unit-validate stage (details)
  4. hack: unmount leftover daemon root folders (details)
  5. Jenkinsfile: reduce time of integration tests by dividing tests into 3 (details)
  6. add powerpc-master stage to Jenkinsfile (details)
  7. add z-master stage to Jenkinsfile (details)
  8. set timeouts in Jenkinsfile to 2 hrs (details)
  9. use environment for power jobs in Jenkinsfile (details)
  10. use environment for z jobs in Jenkinsfile (details)
  11. be more lenient on junit report gathering in Jenkinsfile (details)
  12. rename z bundles in Jenkinsfile (details)
  13. rename powerpc bundles in Jenkinsfile (details)
  14. fix bundles filenames in Jenkinsfile (details)
  15. fix some spelling mistakes (details)
  16. Jenkinsfile: send junit.xml in the stage that produced it (details)
  17. Jenkinsfile: collect junit.xml for all architectures (details)
  18. Bump golang 1.12.8 (CVE-2019-9512, CVE-2019-9514) (details)
  19. Adjust tests for changes in Go 1.12.8 / 1.11.13 (details)
  20. Dockerfile: update CRIU to v3.12 (details)
  21. vendor: update buildkit to v0.6.1 (details)
  22. Fixups for 39695 - edit comments, redundant lines (details)
  23. builder-next: avoid double unmounting mountable (details)
  24. Bump Golang 1.12.9 (details)
  25. builder-next: close build context upload on cancel (details)
  26. Dockerfile: add python3-wheel back again (for yamllint) (details)
Commit 6f5c377ddce449bdf297fd4cab1f71e57788f883 by Sebastiaan van Stijn
docker-py: skip PullImageTest::test_pull_invalid_platform
and remove `PullImageTest::test_build_invalid_platform` from the list,
which was a copy/paste error in f8cde0b32d86fa2df71ec65adc3d45f862b3ea33
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The file was modified hack/make/test-docker-py (diff)
Commit 2ff9ac4de5fbd4c6afc215373362ea65f4a44fbc by Sebastiaan van Stijn
Dockerfile: use DEBIAN_FRONTEND=noninteractive
Using a build-arg so that we don't have to specify it for each
`apt-get install`, and to preserve that the `DEBIAN_FRONTEND` is
preserved in the image itself (which changes the default behavior, and
can be surprising if the image is run interactively).`
With this patch, some (harmless, but possibly confusing) errors are no
longer printed during build, for example:
```patch
Unpacking libgcc1:armhf (1:6.3.0-18+deb9u1) ...
Selecting previously unselected package libc6:armhf.
Preparing to unpack .../04-libc6_2.24-11+deb9u4_armhf.deb ...
-debconf: unable to initialize frontend: Dialog
-debconf: (TERM is not set, so the dialog frontend is not usable.)
-debconf: falling back to frontend: Readline
Unpacking libc6:armhf (2.24-11+deb9u4) ...
Selecting previously unselected package libgcc1:arm64.
Preparing to unpack .../05-libgcc1_1%3a6.3.0-18+deb9u1_arm64.deb ...
Unpacking libgcc1:arm64 (1:6.3.0-18+deb9u1) ...
Selecting previously unselected package libc6:arm64.
Preparing to unpack .../06-libc6_2.24-11+deb9u4_arm64.deb ...
-debconf: unable to initialize frontend: Dialog
-debconf: (TERM is not set, so the dialog frontend is not usable.)
-debconf: falling back to frontend: Readline
```
Looks like some output is now also printed on stdout instead of stderr
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The file was modified Dockerfile (diff)
Commit 251c8dca2832e109f61a589e85d80436b6f53a9c by andrewhsu
Jenkinsfile: move static and cross compilation to unit-validate stage
Signed-off-by: Tibor Vass <tibor@docker.com>
The file was modified Jenkinsfile (diff)
Commit 13df617d4cc98fe31f3ded78902119a1c1505005 by andrewhsu
hack: unmount leftover daemon root folders
Signed-off-by: Tibor Vass <tibor@docker.com>
The file was modified hack/make/.integration-daemon-stop (diff)
Commit e554fb23c82bd672436800dac3ea9739da8e3377 by andrewhsu
Jenkinsfile: reduce time of integration tests by dividing tests into 3
parallel runs
Signed-off-by: Tibor Vass <tibor@docker.com>
The file was modified internal/test/daemon/daemon.go (diff)
The file was modified Makefile (diff)
The file was modified Jenkinsfile (diff)
The file was modified hack/make/test-integration (diff)
Commit c2f9d58375fcccf7b6492acaf1c5ff8a705d0725 by andrewhsu
add powerpc-master stage to Jenkinsfile
The powerpc-master stage will just run the integration-cli tests. The
existing powerpc stage will run the unit tests and the integration
tests. In this way, PR check jobs will be shorter, but all integration
tests will run after PR is merged to master.
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The file was modified Jenkinsfile (diff)
Commit bdc1c1a02a791fcdf84618939274ef9957cc7ca8 by andrewhsu
add z-master stage to Jenkinsfile
The z-master stage will just run the integration-cli tests. The existing
z stage will run the unit tests and the integration tests. In this way,
PR check jobs will be shorter, but all integration tests will run after
PR is merged to master.
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The file was modified Jenkinsfile (diff)
Commit bf70a5975d73ba6833b4a644b4057e9b4ba5f6d5 by andrewhsu
set timeouts in Jenkinsfile to 2 hrs
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The file was modified Jenkinsfile (diff)
Commit 3564b03fbc5e050b4be04512fd1079a5dd355219 by andrewhsu
use environment for power jobs in Jenkinsfile
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The file was modified Jenkinsfile (diff)
Commit 4e2f39cf1447ffd2abd6d0eb1d828c38b3496aa0 by andrewhsu
use environment for z jobs in Jenkinsfile
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The file was modified Jenkinsfile (diff)
Commit 0cfc1ec2bdcdb94dcb60dfdfead86aa4aa737195 by andrewhsu
be more lenient on junit report gathering in Jenkinsfile
In case a job fails before even generating a report file.
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The file was modified Jenkinsfile (diff)
Commit a049ea1a9301b8804775c719f369a7bc8b5cecc9 by andrewhsu
rename z bundles in Jenkinsfile
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The file was modified Jenkinsfile (diff)
Commit ad29f9e471bcad61b66e813845598c7e61e3385c by andrewhsu
rename powerpc bundles in Jenkinsfile
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The file was modified Jenkinsfile (diff)
Commit eb30f0ad8448d27cf9303744596ee0310457f0b9 by andrewhsu
fix bundles filenames in Jenkinsfile
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The file was modified Jenkinsfile (diff)
Commit f6226a2a56c38b790b59393ff4ce7f88f790c811 by qiushida
fix some spelling mistakes
Signed-off-by: SataQiu <qiushida@beyondcent.com>
The file was modified integration-cli/docker_cli_restart_test.go (diff)
The file was modified MAINTAINERS (diff)
The file was modified api/swagger.yaml (diff)
Commit 7f9328ad2e4f2c8aecac9a69f21616943711dc64 by Sebastiaan van Stijn
Jenkinsfile: send junit.xml in the stage that produced it
This will send the results directly after the tests complete, and make
the stage more atomic.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The file was modified Jenkinsfile (diff)
Commit e2f5b78e780f2ad0d69f7abdfdada17a0ff66bb2 by Sebastiaan van Stijn
Jenkinsfile: collect junit.xml for all architectures
Jenkins groups them per stage, so collecting them for all architectures
is possible (without them conflicting or becoming ambiguous)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The file was modified Jenkinsfile (diff)
Commit 73b0e4c58995927ab31e0e42351de7cdefe96e55 by Sebastiaan van Stijn
Bump golang 1.12.8 (CVE-2019-9512, CVE-2019-9514)
go1.12.8 (released 2019/08/13) includes security fixes to the net/http
and net/url packages. See the Go 1.12.8 milestone on our issue tracker
for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.12.8
- net/http: Denial of Service vulnerabilities in the HTTP/2
implementation
net/http and golang.org/x/net/http2 servers that accept direct
connections from untrusted
clients could be remotely made to allocate an unlimited amount of
memory, until the program
crashes. Servers will now close connections if the send queue
accumulates too many control
messages.
The issues are CVE-2019-9512 and CVE-2019-9514, and Go issue
golang.org/issue/33606.
Thanks to Jonathan Looney from Netflix for discovering and reporting
these issues.
This is also fixed in version v0.0.0-20190813141303-74dc4d7220e7 of
golang.org/x/net/http2.
net/url: parsing validation issue
- url.Parse would accept URLs with malformed hosts, such that the Host
field could have arbitrary
suffixes that would appear in neither Hostname() nor Port(), allowing
authorization bypasses
in certain applications. Note that URLs with invalid, not numeric ports
will now return an error
from url.Parse.
The issue is CVE-2019-14809 and Go issue golang.org/issue/29098.
Thanks to Julian Hector and Nikolai Krein from Cure53, and Adi Cohen
(adico.me) for discovering
and reporting this issue.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The file was modified TESTING.md (diff)
The file was modified Dockerfile.windows (diff)
The file was modified Dockerfile (diff)
The file was modified Dockerfile.e2e (diff)
The file was modified Dockerfile.simple (diff)
Commit 683766613a8c1dca8f95b19ddb7e083bb3aef266 by Sebastiaan van Stijn
Adjust tests for changes in Go 1.12.8 / 1.11.13
``` 00:38:11 === Failed 00:38:11 === FAIL: opts
TestParseDockerDaemonHost (0.00s) 00:38:11     hosts_test.go:87: tcp
tcp:a.b.c.d address expected error "Invalid bind address format:
tcp:a.b.c.d" return, got "parse tcp://tcp:a.b.c.d: invalid port
\":a.b.c.d\" after host" and addr 00:38:11     hosts_test.go:87: tcp
tcp:a.b.c.d/path address expected error "Invalid bind address format:
tcp:a.b.c.d/path" return, got "parse tcp://tcp:a.b.c.d/path: invalid
port \":a.b.c.d\" after host" and addr 00:38:11 00:38:11 === FAIL: opts
TestParseTCP (0.00s) 00:38:11     hosts_test.go:129: tcp tcp:a.b.c.d
address expected error Invalid bind address format: tcp:a.b.c.d return,
got parse tcp://tcp:a.b.c.d: invalid port ":a.b.c.d" after host and addr
00:38:11     hosts_test.go:129: tcp tcp:a.b.c.d/path address expected
error Invalid bind address format: tcp:a.b.c.d/path return, got parse
tcp://tcp:a.b.c.d/path: invalid port ":a.b.c.d" after host and addr
```
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The file was modified opts/hosts_test.go (diff)
Commit 00ad0222cef8024f19394e2e9d5dc0e05f0ec982 by Sebastiaan van Stijn
Dockerfile: update CRIU to v3.12
New features
- build CRIU with Android NDK
- C/R of
- IP RAW sockets
- lsm: dump and restore any SELinux process label
- support restoring ghost files on readonly mounts
Bugfixes
- Do not lock network if running in the host network namespace
- Fix RPC configuration file handling
- util: don't leak file descriptors to third-party tools
- small fixes here and there
Improvements
- travis: switch to the Ubuntu Xenial
- travis-ci: Enable ia32 tests
- Many improvements and bug fixes in the libcriu
- Changes in the API and ABI (SONAME increased from 1 to 2)
full diff:
https://github.com/checkpoint-restore/criu/compare/v3.11...v3.12
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The file was modified Dockerfile (diff)
Commit e59b26087fffe0357d34b400740e2fb15c062cb5 by Tõnis Tiigi
vendor: update buildkit to v0.6.1
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
The file was modified vendor.conf (diff)
The file was modified vendor/github.com/moby/buildkit/solver/jobs.go (diff)
The file was modified vendor/github.com/moby/buildkit/solver/pb/caps.go (diff)
The file was modified vendor/github.com/moby/buildkit/cache/remotecache/inline/inline.go (diff)
The file was modified vendor/github.com/moby/buildkit/cache/remotecache/import.go (diff)
The file was modified vendor/github.com/moby/buildkit/frontend/dockerfile/dockerfile2llb/convert_runmount.go (diff)
The file was modified vendor/github.com/moby/buildkit/solver/combinedcache.go (diff)
The file was modified vendor/github.com/moby/buildkit/solver/llbsolver/ops/exec.go (diff)
The file was modified vendor/github.com/moby/buildkit/cache/remotecache/v1/utils.go (diff)
The file was modified vendor/github.com/moby/buildkit/frontend/dockerfile/dockerfile2llb/convert.go (diff)
The file was modified vendor/github.com/moby/buildkit/source/git/gitsource.go (diff)
The file was modified vendor/github.com/moby/buildkit/frontend/dockerfile/builder/build.go (diff)
Commit b146b2382cd768543faf6660efec4f3c76d3ef37 by vikrambir.singh
Fixups for 39695 - edit comments, redundant lines
1. Modify comments added in 5858a99267822b93e2d304d876bab84d05b227c6
Windows Volume GUID path format is: \\?\Volume{<GUID Value>}\<path>
Rewrote the example given in comments to conform to the format..
2. Remove two redundant asserts[assert.NilError]. They are redundant
because the last statement will not change the value of err.
Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
The file was modified builder/dockerfile/copy.go (diff)
The file was modified integration/build/build_test.go (diff)
Commit 9ea2cf320ad2687a51aea1ed849f86f465cbc1d9 by Tõnis Tiigi
builder-next: avoid double unmounting mountable
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
The file was modified builder/builder-next/adapters/snapshot/snapshot.go (diff)
Commit 01d6a566997784e44c34eb4b06bd9bc022237d4e by zhangjintao9020
Bump Golang 1.12.9
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
The file was modified Dockerfile.e2e (diff)
The file was modified Dockerfile.simple (diff)
The file was modified Dockerfile.windows (diff)
The file was modified Dockerfile (diff)
Commit 2c2cd9b86a2e738b1ccf379971e4a0235ab9c758 by Tõnis Tiigi
builder-next: close build context upload on cancel
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
The file was modified builder/builder-next/reqbodyhandler.go (diff)
Commit ad70bf6866ac40753d0f629269169b4be74e2ad0 by Sebastiaan van Stijn
Dockerfile: add python3-wheel back again (for yamllint)
Although the Dockerfile builds without it, adding wheel back should save
some time
``` 00:45:28  #14 10.70 Building wheels for collected packages:
pathspec, pyyaml 00:45:28  #14 10.70   Running setup.py bdist_wheel for
pathspec: started 00:45:28  #14 10.88   Running setup.py bdist_wheel for
pathspec: finished with status 'error' 00:45:28  #14 10.88   Complete
output from command /usr/bin/python3 -u -c "import setuptools,
tokenize;__file__='/tmp/pip-build-mbotnxes/pathspec/setup.py';f=getattr(tokenize,
'open', open)(__file__);code=f.read().replace('\r\n',
'\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d
/tmp/tmpg9pl4u6kpip-wheel- --python-tag cp35: 00:45:28  #14 10.88 
usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] 00:45:28
#14 10.88      or: -c --help [cmd1 cmd2 ...] 00:45:28  #14 10.88    
or: -c --help-commands 00:45:28  #14 10.88      or: -c cmd --help
00:45:28  #14 10.88 00:45:28  #14 10.88   error: invalid command
'bdist_wheel' 00:45:28  #14 10.88 00:45:28  #14 10.88 
---------------------------------------- 00:45:28  #14 10.88   Failed
building wheel for pathspec 00:45:28  #14 10.88   Running setup.py clean
for pathspec 00:45:28  #14 11.05   Running setup.py bdist_wheel for
pyyaml: started 00:45:28  #14 11.25   Running setup.py bdist_wheel for
pyyaml: finished with status 'error' 00:45:28  #14 11.25   Complete
output from command /usr/bin/python3 -u -c "import setuptools,
tokenize;__file__='/tmp/pip-build-mbotnxes/pyyaml/setup.py';f=getattr(tokenize,
'open', open)(__file__);code=f.read().replace('\r\n',
'\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d
/tmp/tmpyci_xi0bpip-wheel- --python-tag cp35: 00:45:28  #14 11.25 
usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] 00:45:28
#14 11.25      or: -c --help [cmd1 cmd2 ...] 00:45:28  #14 11.25    
or: -c --help-commands 00:45:28  #14 11.25      or: -c cmd --help
00:45:28  #14 11.25 00:45:28  #14 11.25   error: invalid command
'bdist_wheel' 00:45:28  #14 11.25 00:45:28  #14 11.25 
---------------------------------------- 00:45:28  #14 11.25   Failed
building wheel for pyyaml 00:45:28  #14 11.25   Running setup.py clean
for pyyaml 00:45:28  #14 11.44 Failed to build pathspec pyyaml 00:45:28
#14 11.45 Installing collected packages: pathspec, pyyaml, yamllint
00:45:28  #14 11.45   Running setup.py install for pathspec: started
00:45:29  #14 11.73     Running setup.py install for pathspec: finished
with status 'done' 00:45:29  #14 11.73   Running setup.py install for
pyyaml: started 00:45:29  #14 12.05     Running setup.py install for
pyyaml: finished with status 'done' 00:45:29  #14 12.12 Successfully
installed pathspec-0.5.9 pyyaml-5.1.2 yamllint-1.16.0
```
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The file was modified Dockerfile (diff)